Add HTTP2FrameConvertible and HTTP2FramePayloadConvertible #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As part of the work for apple#214 to enforce stream creation order we need to remove the requirement that the data sent over the stream be aware of its stream ID ahead of time. This requires that the channel transporting the data provide the stream ID. As such we need a way to convert between data with stream IDs and data without stream IDs. Modifications: - Add 'HTTP2FrameConvertible' protocol whose conforming types can make an 'HTTP2Frame'. - Add 'HTTP2FramePayloadConvertible' protocol whose conforming types can make an 'HTTP2Frame.FramePayload'. - Conform 'HTTP2Frame' and 'HTTP2Frame.FramePayload' to the above protocols. Result: We have a protocol which an HTTP2 stream channel may be generic over.
glbrntt
added
the
🔼 needs-minor-version-bump
glbrntt
added
patch-version-bump-only
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the work for #214 to enforce stream creation order we need to
remove the requirement that the data sent over the stream be aware of
its stream ID ahead of time. This requires that the channel transporting
the data provide the stream ID. As such we need a way to convert between
data with stream IDs and data without stream IDs.
Modifications:
an 'HTTP2Frame'.
an 'HTTP2Frame.FramePayload'.
protocols.
Result:
We have a protocol which an HTTP2 stream channel may be generic over.