Add HTTP2Frame.FramePayload codecs #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
added
the
🔼 needs-minor-version-bump
8 tasks
Lukasa
approved these changes
Jul 31, 2020
|
@glbrntt has some conflicts in |
Motivation: As part of the work for apple#214 we need new codecs which transform `HTTP2Frame.FramePayload` to and from the appropriate request and response parts. Modifications: - Add `HTTP2FramePayloadToHTTP1ClientCodec` - Add `HTTP2FramePayloadToHTTP1ServerCodec` - Duplicate the HTTP2ToHTTP1CodecTests and update the relevant parts to use payloads instead of frames. - Add relevant test helpers. - Note: the HTTP2 to HTTP1 (frame based) codecs haven't been deprecated: doing so without warnings depends on apple#221. Result: - We can transform `HTTP2Frame.FramePayload` types to the relevant HTTP client and server request and response types.
glbrntt
force-pushed
the
gb-frame-payload-codecs
branch
from
5373591
to
b8d75a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the work for #214 we need new codecs which transform
HTTP2Frame.FramePayloadto and from the appropriate request andresponse parts.
Modifications:
HTTP2FramePayloadToHTTP1ClientCodecHTTP2FramePayloadToHTTP1ServerCodecuse payloads instead of frames.
doing so without warnings depends on Allow payload-based stream channels to be created. #221.
Result:
HTTP2Frame.FramePayloadtypes to the relevant HTTPclient and server request and response types.