Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerMaximumMessageLength option for SSH child channels. #101

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Add PeerMaximumMessageLength option for SSH child channels. #101

merged 3 commits into from
Nov 22, 2021

Conversation

gwynne
Copy link
Contributor

@gwynne gwynne commented Nov 18, 2021

Fixes #99 (see issue for details).

@swift-server-bot
Copy link

Can one of the admins verify this patch?

5 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@Lukasa
Copy link
Collaborator

Lukasa commented Nov 22, 2021

@swift-server-bot test this please

@Lukasa Lukasa added the semver/minor Adds new public API. label Nov 22, 2021
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

@Lukasa
Copy link
Collaborator

Lukasa commented Nov 22, 2021

@gwynne Mind cleaning up the soundness check and updating to the tip of main?

@Lukasa Lukasa merged commit eb4355b into apple:main Nov 22, 2021
@gwynne gwynne deleted the maxmessagesize-child-channel-option branch November 24, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child channels can not access their own peerMaxMessageSize
3 participants