Generate up to 8 random padding bytes at a time instead of 4 #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a (presumably copy-pasta) typo in
ByteBuffer.writeSSHPaddingBytes(count:)
where only 4 random bytes would be requested from theCSPRNG
at a time even when 8 or more were needed. The only impact of this issue is a very small performance penalty (so small that it's likely unmeasurable outside of microbenchmarks in practice, in fact), but might as well fix it anyhow.