Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swift-atomics instead of NIOAtomics #117

Merged
merged 1 commit into from Jul 8, 2022
Merged

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Jul 8, 2022

NIOAtomics was deprecated in apple/swift-nio#2204 in favor of swift-atomics https://github.com/apple/swift-atomics
In addition, the @preconcrrency imports of NIOCore are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from main are not required.

@dnadoba dnadoba added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks David!

@glbrntt glbrntt merged commit 27bf96b into apple:main Jul 8, 2022
@dnadoba dnadoba deleted the dn-atomics branch July 8, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants