Deprecate NIOAtomics in favor of Atomics
#2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Note that |
Lukasa
added
the
🔼 needs-minor-version-bump
|
@swift-nio-bot add to allowlist |
|
I’ll ping on apple/swift-atomics#45 for this. |
|
|
dnadoba
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Thanks a lot @stevapple! Looks good from my side but we definitely need to wait for Cory's review.
Lukasa
approved these changes
Jun 28, 2022
|
@swift-nio-bot test this please |
dnadoba
added a commit
to dnadoba/swift-nio-ssh
that referenced
this pull request
Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
dnadoba
added a commit
to dnadoba/swift-nio-ssh
that referenced
this pull request
Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
dnadoba
added a commit
to dnadoba/swift-nio-http2
that referenced
this pull request
Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
glbrntt
pushed a commit
to apple/swift-nio-ssh
that referenced
this pull request
Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
dnadoba
added a commit
to dnadoba/async-http-client
that referenced
this pull request
Jul 11, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
glbrntt
pushed a commit
to apple/swift-nio-http2
that referenced
this pull request
Jul 11, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Jul 11, 2022
Motivation: NIO deprecated its atomics in apple/swift-nio#2204. Modifications: - Use swift-atomics in the `QPSBenchmark` sub-package - Use a lock in the one test which used `NIOAtomic` Result: Not using deprecated code.
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Jul 11, 2022
Motivation: NIO deprecated its atomics in apple/swift-nio#2204. Modifications: - Use swift-atomics in the `QPSBenchmark` sub-package - Use a lock in the one test which used `NIOAtomic` Result: Not using deprecated code.
glbrntt
added a commit
to grpc/grpc-swift
that referenced
this pull request
Jul 12, 2022
Motivation: NIO deprecated its atomics in apple/swift-nio#2204. Modifications: - Use swift-atomics in the `QPSBenchmark` sub-package - Use a lock in the one test which used `NIOAtomic` Result: Not using deprecated code.
dnadoba
added a commit
to swift-server/async-http-client
that referenced
this pull request
Jul 13, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
Joannis
pushed a commit
to Joannis/swift-nio-ssh
that referenced
this pull request
Nov 9, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
IceRocky
added a commit
to IceRocky/grpc-swift
that referenced
this pull request
May 28, 2024
Motivation: NIO deprecated its atomics in apple/swift-nio#2204. Modifications: - Use swift-atomics in the `QPSBenchmark` sub-package - Use a lock in the one test which used `NIOAtomic` Result: Not using deprecated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
NIOAtomicsin favor ofAtomics, and replace all usages ofNIOAtomic.Motivation:
Since we have an official
Atomicslibrary, we can move from our ownAtomicsimplementation to it.Resolves #1948.
Modifications:
NIOAtomicandUnsafeEmbeddedAtomicwrapper types are now deprecated;NIOAtomictoManagedAtomic.Result:
We no longer need to maintain our own atomic types.
NIO will gain a dependency on
swift-atomicspackage.