Commits on Nov 7, 2022

1. refactoring of the encryptPacket method …

   Motivation:
   I think there is a bit of a mix of responsibilities between
   TransportProtection and PacketSerializer. PacketSerializer is
   responsible for writing out plaintext packet structure, but encrypted
   packet structure is written out by the TransportProtection
   implementations. This means that we will have duplicate implementations
   of basic packet writing logic, every implementation of TP will have to
   write length, padding length, payload and padding. Also, right now this
   API uses EncryptablePayload, which we cannot make fully public and
   accessible for writing tests as it will mean making all SSHMessages
   public as well.
   
   Modifications:
    - Extract packet writing logic to a separate function that will be
      used by both plaintext and ciphertext modes
    - Removes usage of EncryptablePayload
    - Write plaintext packet structure (including payload) in the parser
    - TransportProtection implementations now only have to encrypt and tag

   

   artemredkin committed Nov 7, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for f31df60
   • Browse repository at this point

   Copy the full SHA

   f31df60 View commit details

   Browse the repository at this point in the history