No creating SSH channels after disconnect. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If the channel has been disconnected, we should forbid any attempt to create an SSH channel. While we have a number of ways to catch this, in some weirder environments it's possible none of them succeed, so let's take a wider view of how to create these channels by preventing them being created as early as possible as well. Modifications: - Change early-exit guard to only fire during the first handshake. - If we are in the disconnected state, drop channel creation immediately. Result: Better defense against losing channel creation events.
Lukasa
added
the
patch-version-bump-only
artemredkin
approved these changes
Aug 19, 2020
artemredkin
pushed a commit
to artemredkin/swift-nio-ssh
that referenced
this pull request
Feb 19, 2021
Motivation: If the channel has been disconnected, we should forbid any attempt to create an SSH channel. While we have a number of ways to catch this, in some weirder environments it's possible none of them succeed, so let's take a wider view of how to create these channels by preventing them being created as early as possible as well. Modifications: - Change early-exit guard to only fire during the first handshake. - If we are in the disconnected state, drop channel creation immediately. Result: Better defense against losing channel creation events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If the channel has been disconnected, we should forbid any attempt to
create an SSH channel. While we have a number of ways to catch this, in
some weirder environments it's possible none of them succeed, so let's
take a wider view of how to create these channels by preventing them
being created as early as possible as well.
Modifications:
immediately.
Result:
Better defense against losing channel creation events.