Implement certified public key client auth #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemredkin
force-pushed
the
implement_certified_key_in_client_auth
branch
from
ada5843
to
2d79e4d
Compare
artemredkin
force-pushed
the
implement_certified_key_in_client_auth
branch
2 times, most recently
from
140b8cd
to
2cf4d21
Compare
Lukasa
reviewed
Jan 13, 2021
| XCTAssertNoThrow(try self.beginAuthentication(stateMachine: &stateMachine)) | ||
| stateMachine.sendServiceRequest(.init(service: "ssh-userauth")) | ||
|
|
||
| let dataToSign = UserAuthSignablePayload(sessionIdentifier: self.sessionID, userName: "foo", serviceName: "ssh-connection", publicKey: delegate.key.publicKey) |
There was a problem hiding this comment.
This doesn't look like it'll compile. Is there a key member on InfinitePrivateKey delegate?
There was a problem hiding this comment.
I'm using the wrong delegate type 🤦🏻♂️ give me a minute
Lukasa
requested changes
Jan 13, 2021
| @@ -720,4 +730,27 @@ final class UserAuthenticationStateMachineTests: XCTestCase { | |||
| // Let's say we got a success. Happy path! | |||
| XCTAssertNoThrow(try stateMachine.receiveUserAuthSuccess()) | |||
| } | |||
|
|
|||
| func testCertificateClientAuthFlow() throws { | |||
| let delegate = InfinitePrivateKeyDelegate() | |||
There was a problem hiding this comment.
This test is wrong: you aren't using your new delegate.
Motivation: Right now there is no way to use certified public keys for user auth. Modifications: 1. Adds new init to PrivateKey 2. Updates UserAuthRequestMessage to support public key 3. Adds a test Result: Closes apple#63
artemredkin
force-pushed
the
implement_certified_key_in_client_auth
branch
from
2cf4d21
to
545cf28
Compare
Lukasa
added
the
🔼 needs-minor-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Right now there is no way to use certified public keys for user auth.
Modifications:
Result:
Closes #63