Adds emittion of user authentication success event. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
artemredkin
force-pushed
the
add_userauth_success_event
branch
from
b05da8d
to
cf827da
Compare
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
artemredkin
force-pushed
the
add_userauth_success_event
branch
from
cf827da
to
14a068d
Compare
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
approved these changes
Mar 3, 2021
| @@ -16,6 +16,9 @@ protocol AcceptsUserAuthMessages { | |||
| var userAuthStateMachine: UserAuthenticationStateMachine { get set } | |||
| } | |||
|
|
|||
| /// This event indicates that server accepted our response to authentication challenge. SSH session can be considered active after that. | |||
| public struct UserAuthSuccessEvent {} | |||
There was a problem hiding this comment.
Can we add a public init to this? Otherwise users can't construct instances of it. We should also make it Hashable.
|
One little nit and then we're good to go. |
Motivation: Currently there is now way to wait for successful SSH session establishment, the only way to continue is to try to create a child channel. Given that most clients are expecting the session to be active when both key exchange and user authenticaiton complete, I propose to emit UserAuthSuccessEvent. That way client can wait for that event or fail if there is an error in the pipeline. Modifications: - Adds UserAuthSuccessEvent event - Adds .event case to StateMachineInboundProcessResult - Adds emittion of event if StateMachineInboundProcessResult is .event - Adds two tests Result: Closes apple#39
artemredkin
force-pushed
the
add_userauth_success_event
branch
from
14a068d
to
62077dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently there is now way to wait for successful SSH session
establishment, the only way to continue is to try to create a child
channel. Given that most clients are expecting the session to be active
when both key exchange and user authenticaiton complete, I propose to
emit UserAuthSuccessEvent. That way client can wait for that event or
fail if there is an error in the pipeline.
Modifications:
Result:
Closes #39