Add support from synchronous options #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NIO 2.27.0 added a customisation point to `Channel` to allow options to be fetched synchronously if the caller is on the appropriate event loop. Modifications: - Add synchronous options to SSHChildChannel - Promote event loop assertions to preconditions Result: Callers can fetch channel options synchronously on 'SSHChildChannel's.
Lukasa
added
the
patch-version-bump-only
Lukasa
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIO 2.27.0 added a customisation point to
Channelto allow options tobe fetched synchronously if the caller is on the appropriate event loop.
Modifications:
Result:
Callers can fetch channel options synchronously on 'SSHChildChannel's.