Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the ContiguousBytes functions for setting data #84

Merged
merged 1 commit into from
May 11, 2021
Merged

Use the ContiguousBytes functions for setting data #84

merged 1 commit into from
May 11, 2021

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented May 11, 2021

Motivation:

We should use setContiguousBytes instead of setBytes to avoid hitting
the slow path.

Modifications:

  • Use setContiguousBytes.

Result:

Speedy speedy

@Lukasa
Use the ContiguousBytes functions for setting data
966718a 
Motivation:

We should use setContiguousBytes instead of setBytes to avoid hitting
the slow path.

Modifications:

- Use setContiguousBytes.

Result:

Speedy speedy
@Lukasa Lukasa added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label May 11, 2021
@Lukasa Lukasa requested review from artemredkin and weissi May 11, 2021 16:27
weissi
weissi approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lukasa Lukasa merged commit 323b3ef into apple:main May 11, 2021
@Lukasa Lukasa deleted the cb-use-better-write-function branch May 11, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

@artemredkin artemredkin Awaiting requested review from artemredkin

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lukasa @weissi