Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Swift 5.1 #87

Merged
merged 7 commits into from
Jun 22, 2021
Merged

Conversation

Davidde94
Copy link
Contributor

Changes made:

Removed CI config for 5.1
Changed 5.2 to be based on 16.04 so we have some coverage there
Converted Package.swift to the latest syntax
Added a description to supported Swift versions in the README

@Davidde94
Copy link
Contributor Author

Davidde94 commented Jun 22, 2021

Hey @yim-lee some more CI playing if you don't mind! Could you please:

  • Remove the 5.1 jobs
  • Update the 5.2 job to use 16.04
  • Update the API breakage to be based on the Swift 5.4 Ubuntu 20.04 image

@Lukasa Lukasa added the 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Jun 22, 2021
@yim-lee
Copy link
Member

yim-lee commented Jun 22, 2021

@swift-server-bot test this please

1 similar comment
@yim-lee
Copy link
Member

yim-lee commented Jun 22, 2021

@swift-server-bot test this please

@yim-lee
Copy link
Member

yim-lee commented Jun 22, 2021

@Davidde94 CI changes are done.

  • This project doesn't have api-breakage job :)
  • Added 5.4 job to required list
  • Fixed 5.5 job
  • 5.2 and soundness failures look legit

@Davidde94
Copy link
Contributor Author

@yim-lee it looks like this is a failure in TSan itself. Could we try swapping the 5.3 job to 16.04, and the 5.2 job to 18.04. I've pushed up the necessary files.

@Davidde94
Copy link
Contributor Author

@yim-lee could you take another look when you get the chance please?

@yim-lee
Copy link
Member

yim-lee commented Jun 22, 2021

it looks like this is a failure in TSan itself. Could we try swapping the 5.3 job to 16.04, and the 5.2 job to 18.04. I've pushed up the necessary files.

@Davidde94 done.

@swift-server-bot test this please

@Davidde94
Copy link
Contributor Author

Same TSan failure. For now I'll disable the job, we know that it's unreliable.

@yim-lee
Copy link
Member

yim-lee commented Jun 22, 2021

Same TSan failure. For now I'll disable the job, we know that it's unreliable.

@Davidde94 Are there CI changes you want me to make?

@Davidde94
Copy link
Contributor Author

@yim-lee I think this is something I can do myself, I'll push up now

@Davidde94 Davidde94 merged commit 63db5f1 into apple:main Jun 22, 2021
@Davidde94 Davidde94 deleted the de/min-swift-5.2 branch June 22, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants