-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Swift 5.1 #87
Conversation
Hey @yim-lee some more CI playing if you don't mind! Could you please:
|
@swift-server-bot test this please |
1 similar comment
@swift-server-bot test this please |
@Davidde94 CI changes are done.
|
@yim-lee it looks like this is a failure in TSan itself. Could we try swapping the 5.3 job to 16.04, and the 5.2 job to 18.04. I've pushed up the necessary files. |
@yim-lee could you take another look when you get the chance please? |
@Davidde94 done. @swift-server-bot test this please |
Same TSan failure. For now I'll disable the job, we know that it's unreliable. |
@Davidde94 Are there CI changes you want me to make? |
@yim-lee I think this is something I can do myself, I'll push up now |
Changes made:
Removed CI config for 5.1
Changed 5.2 to be based on 16.04 so we have some coverage there
Converted Package.swift to the latest syntax
Added a description to supported Swift versions in the README