Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc generation and jazzy version #92

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented Sep 23, 2021

Motivation:

The combination of Ruby and Jazzy are throwing up issues in CI on older
Ubuntu versions.

Modifications:

  • Only install Jazzy on focal
  • Fix doc generation script to use more recent source-kitten syntax

Results:

  • CI doesn't complain
  • Docs get built

Motivation:

The combination of Ruby and Jazzy are throwing up issues in CI on older
Ubuntu versions.

Modifications:

- Only install Jazzy on focal
- Fix doc generation script to use more recent source-kitten syntax

Results:

- CI doesn't complain
- Docs get built
@Lukasa Lukasa added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Sep 23, 2021
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo. Please fix before merge.

docker/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Fabian Fett <fabianfett@apple.com>
@Lukasa Lukasa merged commit 5c6b4a5 into apple:main Sep 23, 2021
@Lukasa Lukasa deleted the cb-fix-jazzy branch September 23, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants