Fix crash sending window increment after close #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When reads have yet to be delivered to a channel and we receive a CHANNEL_CLOSE message, we forcibly deliver all of the reads. As part of doing this, we process the window size changes and potentially send window increment messages. These messages are invalid to send at this time, and the state machine rightly forbids us from sending them, which causes a crash. Modifications: - Change the code to only futz with the channel window if the channel is still open. Result: No crashing after channel close.
Lukasa
added
the
patch-version-bump-only
Lukasa
requested review from
artemredkin,
glbrntt,
fabianfett and
PeterAdams-A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When reads have yet to be delivered to a channel and we receive a
CHANNEL_CLOSE message, we forcibly deliver all of the reads. As part of
doing this, we process the window size changes and potentially send
window increment messages. These messages are invalid to send at this
time, and the state machine rightly forbids us from sending them, which
causes a crash.
Modifications:
still open.
Result:
No crashing after channel close.