Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BoringSSL to 6ba98ff60144f60aba589b4d6121689528fbae76 #149

Merged
merged 1 commit into from Nov 13, 2019
Merged

Update BoringSSL to 6ba98ff60144f60aba589b4d6121689528fbae76 #149

merged 1 commit into from Nov 13, 2019

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented Nov 13, 2019

No functional changes, but paving the way for a change to the vendoring script.

@Lukasa Lukasa requested a review from weissi November 13, 2019 14:13
@Lukasa
Copy link
Contributor Author

Lukasa commented Nov 13, 2019

@swift-nio-bot test this please

weissi
weissi approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more - than +, looks good :P

@weissi
Copy link
Member

weissi commented Nov 13, 2019

tests too slow

@weissi
Copy link
Member

weissi commented Nov 13, 2019

@swift-nio-bot test this please

@Lukasa
Copy link
Contributor Author

Lukasa commented Nov 13, 2019

I think the 5.1 builder is busted.

@weissi
Copy link
Member

weissi commented Nov 13, 2019

@Lukasa earlier it was just a 10 min timeout

@weissi
Copy link
Member

weissi commented Nov 13, 2019

@swift-nio-bot test this please

1 similar comment
@Lukasa
Copy link
Contributor Author

Lukasa commented Nov 13, 2019

@swift-nio-bot test this please

@Lukasa Lukasa merged commit 63e61ed into apple:master Nov 13, 2019
@Lukasa Lukasa deleted the cb-update-boringssl-20191113 branch November 13, 2019 15:04
@Lukasa Lukasa added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Nov 13, 2019
@Lukasa Lukasa added this to the 2.5.0 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
2.4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lukasa @weissi