Update BoringSSL to 7c522995d1ea5386b3223a19b0f62e73c1f76b17 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove a temporary BoringSSL patch and deal with no C files being in fiat/
Lukasa
added
the
patch-version-bump-only
glbrntt
reviewed
May 12, 2020
| @@ -191,7 +191,7 @@ PATTERNS=( | |||
| 'crypto/*/*/*.S' | |||
| 'crypto/*/*/*/*.c' | |||
| 'third_party/fiat/*.h' | |||
| 'third_party/fiat/*.c' | |||
| #'third_party/fiat/*.c' | |||
There was a problem hiding this comment.
If this remains commented out and files matching this pattern do exist the next time this is run, will there be an obvious failure?
There was a problem hiding this comment.
Yeah, the compile will fail due to missing symbols.
glbrntt
approved these changes
May 12, 2020
|
@swift-nio-bot test this please |
1 similar comment
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a temporary BoringSSL patch and deal with no C files being
in fiat/