Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to support building with Musl. #450

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Changes to support building with Musl. #450

merged 1 commit into from
Dec 7, 2023

Conversation

al45tair
Copy link
Contributor

Define _GNU_SOURCE in the Package.swift.

Add imports for Musl in relevant places.

Remove types from sysXXX static variables.

@FranzBusch
Copy link
Contributor

@swift-server-bot add to allowlist

@FranzBusch
Copy link
Contributor

@swift-server-bot test this please

@Lukasa Lukasa added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Nov 28, 2023
@Lukasa
Copy link
Contributor

Lukasa commented Nov 28, 2023

@swift-server-bot add to allowlist

@Lukasa
Copy link
Contributor

Lukasa commented Nov 28, 2023

This has caused an issue in the nightly compiler:

16:26:49 /code/Sources/NIOSSL/PosixPort.swift:44:26: error: cannot infer type of closure parameter '$0' without a type annotation
16:26:49 private let sysFclose =  { fclose($0!) }
16:26:49                          ^
16:26:49 /code/Sources/NIOSSL/PosixPort.swift:44:26: error: cannot infer type of closure parameter '$0' without a type annotation
16:26:49 private let sysFclose =  { fclose($0!) }
16:26:49                          ^
16:26:49 /code/Sources/NIOSSL/PosixPort.swift:44:26: error: cannot infer type of closure parameter '$0' without a type annotation
16:26:49 private let sysFclose =  { fclose($0!) }
16:26:49                          ^
16:26:49 /code/Sources/NIOSSL/PosixPort.swift:44:26: error: cannot infer type of closure parameter '$0' without a type annotation
16:26:49 private let sysFclose =  { fclose($0!) }
16:26:49                          ^

@al45tair
Changes to support building with Musl.
11a8aa3 
Define `_GNU_SOURCE` in the `Package.swift`.

Add imports for Musl in relevant places.

Remove types from sysXXX static variables.
@Lukasa Lukasa merged commit 0f05af6 into apple:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@al45tair @FranzBusch @Lukasa