-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cxx interop build pipeline #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not confident this is enough: we should also add imports of all the targets we're depending on into the test product. That should force us to actually build everything and confirm they work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick nit and then we're good.
@swift-server-bot add to allowlist |
@yim-lee can thanks for dealing with the pipelines! |
This PR adds a new target to
docker-compose
that builds a new project that depends on this one, with C++ interoperability enabled, with the goal of adding a new CI pipeline that checks the build succeeds.Motivation:
To make sure that C++ interoperability can be used on projects that depend on
swift-nio-ssl
.Modifications:
swift-nio-ssl
, and builds it with C++ interoperability enabled.Result:
We will ensure this projects builds properly with C++ interoperability enabled.