Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cxx interop build pipeline #454

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Add cxx interop build pipeline #454

merged 6 commits into from
Jan 2, 2024

Conversation

gjcairo
Copy link
Contributor

@gjcairo gjcairo commented Dec 19, 2023

This PR adds a new target to docker-compose that builds a new project that depends on this one, with C++ interoperability enabled, with the goal of adding a new CI pipeline that checks the build succeeds.

Motivation:

To make sure that C++ interoperability can be used on projects that depend on swift-nio-ssl.

Modifications:

  • Added a new target to docker-compose that creates a new package that depends on swift-nio-ssl, and builds it with C++ interoperability enabled.
  • Will request a new CI pipeline that runs this new target.

Result:

We will ensure this projects builds properly with C++ interoperability enabled.

scripts/cxx-interop-compatibility.sh Outdated Show resolved Hide resolved
scripts/cxx-interop-compatibility.sh Show resolved Hide resolved
scripts/cxx-interop-compatibility.sh Outdated Show resolved Hide resolved
@gjcairo gjcairo marked this pull request as ready for review December 20, 2023 13:11
@gjcairo gjcairo requested a review from glbrntt December 20, 2023 13:11
@glbrntt glbrntt enabled auto-merge (squash) December 20, 2023 13:30
@Lukasa Lukasa added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Dec 20, 2023
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident this is enough: we should also add imports of all the targets we're depending on into the test product. That should force us to actually build everything and confirm they work.

@gjcairo gjcairo requested a review from Lukasa December 20, 2023 14:06
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick nit and then we're good.

scripts/cxx-interop-compatibility.sh Outdated Show resolved Hide resolved
@yim-lee
Copy link
Member

yim-lee commented Dec 20, 2023

@swift-server-bot add to allowlist

@gjcairo gjcairo requested a review from Lukasa December 20, 2023 19:44
@gjcairo
Copy link
Contributor Author

gjcairo commented Dec 20, 2023

@yim-lee can thanks for dealing with the pipelines!

@glbrntt glbrntt merged commit e0464ed into apple:main Jan 2, 2024
9 of 10 checks passed
@gjcairo gjcairo deleted the cxx-interop branch January 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants