Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end2end tests 12 & 14 are disabled at the moment, fix them #132

Closed
weissi opened this issue Mar 12, 2018 · 0 comments
Closed

end2end tests 12 & 14 are disabled at the moment, fix them #132

weissi opened this issue Mar 12, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@weissi
Copy link
Member

weissi commented Mar 12, 2018

see title, for @weissi to do as he promised that a while ago and then forgot :|

@weissi weissi self-assigned this Mar 12, 2018
@weissi weissi added the bug Something isn't working label Mar 12, 2018
weissi pushed a commit to weissi/swift-nio that referenced this issue Jun 13, 2020
Motivation:

The HTTP2StreamMultiplexer currently passes frames from child streams
through to the rest of the pipeline, and does the same with flushes.
Because HTTP2 is multiplexed, it is highly likely that in any
channelRead cycle multiple child channels will make sufficient progress
to want to flush their results. This means we can end up with multiple,
redundant, flush calls.

It would be better in general to try to reduce the amount of flushing
necessary to no more than once per channelRead cycle.

Modifications:

- Keep track of the channelRead cycle and where we are in it.
- Avoid flushing when we can expect a channelReadComplete.
- Flush on channelReadComplete if necessary.

Result:

Fewer flushes, better performance under high read load.
weissi pushed a commit to weissi/swift-nio that referenced this issue Feb 3, 2024
* SOCKS handshake handler implementation

* Soundness

* Remove placeholder text

* Sad path tests

* Soundness

* Docs

* Fix workflow tests

* Make handler removable

* Protect methods

* Prevent test crashes

* Cleanup public types

* Add test that writing after auth fails

* Add force handler removal tests

* Remove client and server state from public api

* Explicitly handle states

* Remove promises

* Fix test

* Add data to authentication complete

* Refactor to add authentication complete flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant