Add conditional conformances of CircularBuffer to Equatable and Hashable #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
8 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
requested changes
Aug 9, 2019
|
I think we're still missing the tests. |
Lukasa
requested changes
Aug 9, 2019
PopFlamingo
force-pushed
the
cbequatablehashable
branch
2 times, most recently
from
6384d44
to
fee7195
Compare
|
@Lukasa Everything should now be ok! 🙂 |
|
@swift-nio-bot test this please |
Lukasa
requested changes
Aug 10, 2019
Motivation: In general, Swift collections and sequences automatically conforms to Equatable and Hashable when their Element conforms to Equatable and Hashhable, respectively. This wasn't the case of CircularBuffer, which was unintuitive and could cause useless boilerplate code. Modifications: CircularBuffer has been extended so that it conforms to Equatable when its Element is Equatable, and to Hashable when its element is Hashable. Corresponding test cases have been added. Result: Appropriate conditional conformances of CircularBuffer to Equatable and Hashable
PopFlamingo
force-pushed
the
cbequatablehashable
branch
from
fee7195
to
92a0701
Compare
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircularBuffer is now
Equatablewhen itsElementisEquatable, andHashablewhen itsElementisHashableSolves #1098