test that we tolerate out-of-band data #1197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Oct 29, 2019
| public static func sendto(descriptor: CInt, | ||
| pointer: UnsafeRawPointer, | ||
| size: size_t, | ||
| flags: CInt, |
There was a problem hiding this comment.
Isn’t this an API breaking change? Or am I missing something?
How come we have public methods on an internal enum?
Lukasa
added
the
patch-version-bump-only
weissi
force-pushed
the
jw-tolerate-oob
branch
from
713cf14
to
83b0ef4
Compare
weissi
added
🔼 needs-minor-version-bump
|
New test failed on 5.1... 👎 |
Motivation: We don't support OOB data but we should make sure that nothing breaks if OOB arrives. Modifications: Add a test that makes sure we tolerate OOB data. Result: More test coverage.
weissi
force-pushed
the
jw-tolerate-oob
branch
from
83b0ef4
to
c22e552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We don't support OOB data but we should make sure that nothing breaks if
OOB arrives.
Modifications:
Add a test that makes sure we tolerate OOB data.
Result:
More test coverage.