Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some unnecessarily slow tests faster #1365

Merged
merged 2 commits into from Jan 29, 2020
Merged

Conversation

weissi
Copy link
Member

@weissi weissi commented Jan 29, 2020

Motivation:

As can be seen in #1358, we have a bunch of very slow tests.
Some of them are unnecessarily slow.

Modifications:

Make easy to make fast tests faster.

Result:

Faster test suite.

Motivation:

As can be seen in apple#1358, we have a bunch of very slow tests.
Some of them are unnecessarily slow.

Modifications:

Make easy to make fast tests faster.

Result:

Faster test suite.
@weissi weissi requested review from Lukasa and glbrntt January 29, 2020 12:38
@Lukasa Lukasa added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Jan 29, 2020
@Lukasa Lukasa added this to the 2.14.0 milestone Jan 29, 2020
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@weissi weissi merged commit 9f9976a into apple:master Jan 29, 2020
@weissi weissi deleted the jw-faster-tests branch January 29, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants