Add synchronous option to Trunk push #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
10 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
weissi
approved these changes
Jun 9, 2020
|
@Jake-Prickett sorry about the previous comment, your motivation explains it really well. Thank you! |
|
@swift-nio-bot add to whitelist |
Lukasa
added
the
patch-version-bump-only
Lukasa
approved these changes
Jun 9, 2020
|
haha no worries @weissi! Just discovered this yesterday and it'll make life a bit easier for whoever runs it! |
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
Jun 9, 2020
Co-authored-by: Prickett <jpricke1@ford.com>
glbrntt
added a commit
to glbrntt/swift-nio-http2
that referenced
this pull request
Jun 10, 2020
glbrntt
added a commit
to glbrntt/swift-nio-ssl
that referenced
this pull request
Jun 10, 2020
Lukasa
pushed a commit
to apple/swift-nio-http2
that referenced
this pull request
Jun 10, 2020
Lukasa
pushed a commit
to apple/swift-nio-ssl
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add synchronous option to trunk push in podspec script
Motivation:
Currently the
build_podspec.shscript needs to be ran multiple times due to Podspecs not immediately becoming available for sequential Podspecs. This has been an ongoing issue where I have to run the script multiple times manually in order to get all of them through.Modifications:
Add CocoaPods/cocoapods-trunk#147 to the script
Result:
Now, the script will only need to be ran once! 馃帀