Make TimeAmount Hashable
#1571
Merged
Make TimeAmount Hashable
#1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
added
the
🔼 needs-minor-version-bump
|
( |
Lukasa
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Fab. While the API compatibility checker should catch this, want to just add a quick test to validate behaviour? Easiest test is to create three TimeAmount values, two the same and one different, then throw them in a Set and confirm it contains what you expect.
Motivation: TimeAmount wasn't `Hashable` and there's no clear reason it shouldn't be. Modifications: Add synthesized `Hashable` conformance to `TimeAmount` Result: `TimeAmount` is hashable.
glbrntt
force-pushed
the
gb-timeamount-hashable
branch
from
d60ec75
to
a58c951
Compare
|
5.0 failure is #1147 |
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TimeAmount wasn't
Hashableand there's no clear reason it shouldn'tbe.
Modifications:
Add synthesized
Hashableconformance toTimeAmountResult:
TimeAmountis hashable.