Properly allow ThreadPool to be started multiple times. #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Our API documentation claims that NIOThreadPool.start() will tolerate being called multiple times. However, this wasn't actually true: in debug mode it'd hit an assertion, and in release mode it would quietly orphan all its threads and replace them with new ones, leaving there with twice as many threads and some that wouldn't be closed down. We should support the functionality we claim we do. Modifications: - Fixed the incorrect check for running thread pool state. - Added a test to validate we actually allow multiple starts. Result: Thread pools really can be started multiple times.
Lukasa
added
the
patch-version-bump-only
slashmo
pushed a commit
to slashmo/swift-nio
that referenced
this pull request
Aug 18, 2020
Motivation: Our API documentation claims that NIOThreadPool.start() will tolerate being called multiple times. However, this wasn't actually true: in debug mode it'd hit an assertion, and in release mode it would quietly orphan all its threads and replace them with new ones, leaving there with twice as many threads and some that wouldn't be closed down. We should support the functionality we claim we do. Modifications: - Fixed the incorrect check for running thread pool state. - Added a test to validate we actually allow multiple starts. Result: Thread pools really can be started multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our API documentation claims that NIOThreadPool.start() will tolerate
being called multiple times. However, this wasn't actually true: in
debug mode it'd hit an assertion, and in release mode it would quietly
orphan all its threads and replace them with new ones, leaving there
with twice as many threads and some that wouldn't be closed down.
We should support the functionality we claim we do.
Modifications:
Result:
Thread pools really can be started multiple times.