Stop udp connection allocation test hanging on linux. #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Hanging tests make doing work and asserting correctness very difficult. Modifications: Remove address reuse from the server side of the udp channel. Result: The tests no longer hang. (The reason things we hanging was that the client side was occasionally getting assigned the same port number as the server side (extremely agressive port reuse)
glbrntt
reviewed
Jun 29, 2020
| @@ -44,7 +44,6 @@ func run(identifier: String) { | |||
| let serverHandler = CountReadsHandler(numberOfReadsExpected: numberOfIterations, | |||
| completionPromise: group.next().makePromise()) | |||
| let serverChannel = try! DatagramBootstrap(group: group) | |||
| .channelOption(ChannelOptions.socketOption(.so_reuseaddr), value: 1) | |||
There was a problem hiding this comment.
Don't we want to disable this on the client?
There was a problem hiding this comment.
Nah, the server is where it should be disabled. Given that we were binding to 0 there was never any real advantage in having SO_REUSEADDR turned on in this test anyway.
Lukasa
added
the
patch-version-bump-only
Lukasa
approved these changes
Jun 29, 2020
| @@ -44,7 +44,6 @@ func run(identifier: String) { | |||
| let serverHandler = CountReadsHandler(numberOfReadsExpected: numberOfIterations, | |||
| completionPromise: group.next().makePromise()) | |||
| let serverChannel = try! DatagramBootstrap(group: group) | |||
| .channelOption(ChannelOptions.socketOption(.so_reuseaddr), value: 1) | |||
There was a problem hiding this comment.
Nah, the server is where it should be disabled. Given that we were binding to 0 there was never any real advantage in having SO_REUSEADDR turned on in this test anyway.
slashmo
pushed a commit
to slashmo/swift-nio
that referenced
this pull request
Aug 18, 2020
Motivation: Hanging tests make doing work and asserting correctness very difficult. Modifications: Remove address reuse from the server side of the udp channel. Result: The tests no longer hang. (The reason things we hanging was that the client side was occasionally getting assigned the same port number as the server side (extremely agressive port reuse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Hanging tests make doing work and asserting correctness very difficult.
Modifications:
Remove address reuse from the server side of the udp channel.
Result:
The tests no longer hang.
(The reason things we hanging was that the client side was occasionally getting assigned the same port number as the server side (extremely agressive port reuse)