Add alloc counter benchmark for result erasing maps. #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
needs-no-version-bump
glbrntt
approved these changes
May 25, 2021
| // | ||
| // This source file is part of the SwiftNIO open source project | ||
| // | ||
| // Copyright (c) 2017-2019 Apple Inc. and the SwiftNIO project authors |
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2017-2019 Apple Inc. and the SwiftNIO project authors | |
| // Copyright (c) 2021 Apple Inc. and the SwiftNIO project authors |
Motivation: Peter thinks that result-erasing maps should not allocate, and we have special code paths in the code to try to make Void -> Void maps not allocate. Sadly, both code paths currently do allocate. Per our rules for not trying to make optimizations without data, we should start measuing these closures so we can make optimizations. Modifications: - Added an alloc couter test for result-erasing maps. Result: Alloc counter test suitable for any fix of apple#1697.
Lukasa
force-pushed
the
cb-alloc-test-for-convert-to-void
branch
from
67ef93b
to
7c076ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Peter thinks that result-erasing maps should not allocate, and we have
special code paths in the code to try to make Void -> Void maps not
allocate. Sadly, both code paths currently do allocate.
Per our rules for not trying to make optimizations without data, we
should start measuing these closures so we can make optimizations.
Modifications:
Result:
Alloc counter test suitable for any fix of #1697.