add a missing subscript(bounds:) implementation
#1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- an older version of the standard library supplied a bogus implementation by error. Calling *that* would have been a crashing bug.
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Lukasa
approved these changes
Jul 9, 2021
|
@swift-nio-bot add to allowlist |
|
An improvement that is deprecated-on-arrival. 🤷🏽 |
|
This also triggered a failure in the compatibility suite (sorry for failing to notice). |
|
I believe that the Swift team are in charge of updating that. |
Lukasa
added
the
patch-version-bump-only
baarde
added a commit
to baarde/swift-nio
that referenced
this pull request
Aug 26, 2021
Motivation: This is a backport of apple#1893 for SwiftNIO1. Modifications: Add an implementation of subscript(_ bounds:) to StaticString. Result: * StaticString can be sliced without crashing, though in O(n) time. * The package should build with the July 8 2021 snapshot of Swift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An older version of the standard library supplied a bogus implementation by error.
Calling that would have been a crashing bug.
Motivation:
Fix #1892,
which was triggered by apple/swift#38161,
which is a fix for https://bugs.swift.org/browse/SR-14848.
Modifications:
Add the missing
subscript(bounds:)implementation. It should always have been there.Result:
Package should build with the July 8 2021 snapshot of Swift.