disable PTHREAD_MUTEX_ERRORCHECK in release mode #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `pthread_mutex_t` locks can do advanced error checking with `PTHREAD_MUTEX_ERRORCHECK`, the cost of which was unknown. With apple#1994 I could now measure it. The differences from my local machine (M1 MBP) for uncontended locks are: - on Linux: 10% faster without `PTHREAD_MUTEX_ERRORCHECK` - on macOS: 25% faster without `PTHREAD_MUTEX_ERRORCHECK`! Modification: Do the extended error checking only in debug mode. Note that we still `precondition` on all pthread return values (which is basically free). Result: Faster code.
Lukasa
added
the
patch-version-bump-only
Lukasa
approved these changes
Nov 29, 2021
|
@swift-nio-bot test this please |
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
pthread_mutex_tlocks can do advanced error checking withPTHREAD_MUTEX_ERRORCHECK, the cost of which was unknown. With #1994 Icould now measure it.
The differences from my local machine (M1 MBP) for uncontended locks
are:
PTHREAD_MUTEX_ERRORCHECKPTHREAD_MUTEX_ERRORCHECK!Modification:
Do the extended error checking only in debug mode. Note that we still
preconditionon all pthread return values (which is basically free).Result:
Faster code.