Don't tolerate EBADF on close. #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's like that apple#1999 was a little wide, and we should have forbidden EBDAF on close. Modifications: Still forbid EBADF on close. Result: EBADF still preconditions on close.
Lukasa
added
the
patch-version-bump-only
weissi
approved these changes
Dec 3, 2021
|
Thank you @Lukasa |
|
@Lukasa/@John-Connolly turns out there is a |
|
I added a comment to the check that mention this. However, I don't think it's that simple: in the case of accept we'd have to check EBADF on the listening socket, not the one that hit the error. Actually doing this makes the code quite hard, I think, and we get most of the improvement from this version of the patch, so I consider it a future enhancement. |
|
@Lukasa works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's like that #1999 was a little wide, and we should have forbidden
EBDAF on close.
Modifications:
Still forbid EBADF on close.
Result:
EBADF still preconditions on close.
Fixes #2001.