Rebind less load more #2055
Merged
Rebind less load more #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
patch-version-bump-only
glbrntt
reviewed
Mar 2, 2022
Sources/NIOPosix/BaseSocket.swift
Outdated
| $0.withMemoryRebound(to: sockaddr_in.self, capacity: 1) { | ||
| $0.pointee | ||
| } | ||
| return withUnsafeMutableBytes(of: &self) { |
There was a problem hiding this comment.
I think this can be withUnsafeBytes(of:) (and elsewhere)
There was a problem hiding this comment.
I also wonder if this function actually needs to be mutating.
There was a problem hiding this comment.
This func is mutating because on older Swift releases we didn't have a version of withUnsafeBytes that did not take an inout as an argument. It's possible we dropped all the Swift releases where that's true, let me check.
There was a problem hiding this comment.
Seems to be fine, I've updated the PR with removal of the mutatings.
|
@swift-nio-bot test this please |
glessard
approved these changes
Mar 3, 2022
Desdu1184
approved these changes
Mar 6, 2022
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the amount of rebinding we do with sockaddr types.
Motivation:
SR-15912 recently caused a bunch of issues with compilation of NIO in the nightlies. While these were arguably Swift bugs, we're also skating pretty close to the edge by using
withMemoryReboundhere: it's often safer for us to load the structures, rather than use random pointers.Modifications:
Result:
Fewer calls with
withMemoryRebound.