Adopt Sendable in EventLoop.swift
#2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
reviewed
May 10, 2022
Sources/NIOCore/EventLoop.swift
Outdated
| @@ -19,15 +19,28 @@ import Dispatch | |||
| /// | |||
| /// A `Scheduled` allows the user to either `cancel()` the execution of the scheduled task (if possible) or obtain a reference to the `EventLoopFuture` that | |||
| /// will be notified once the execution is complete. | |||
| public struct Scheduled<T> { | |||
| public struct Scheduled<T>: NIOSendable { | |||
There was a problem hiding this comment.
Does this need to be preconcurrency? We can only be Sendable where the generic type is Sendable.
There was a problem hiding this comment.
Good question and I think the question boils down to if EventLoopPromise should be unconditionality Sendable or not.
There was a problem hiding this comment.
I have made it only conditionally Sendable as EventLoopPromise should have been only conditionally Sendable as well.
Lukasa
reviewed
May 13, 2022
Sources/NIOCore/EventLoop.swift
Outdated
| #endif | ||
|
|
||
| #if swift(>=5.6) | ||
| @preconcurrency |
There was a problem hiding this comment.
Does @preconcurrency do anything for us if this is internal only?
There was a problem hiding this comment.
it isn't necessary here, removed.
Sources/NIOCore/EventLoop.swift
Outdated
| /* private but usableFromInline */ @usableFromInline let _cancellationTask: () -> Void | ||
| #endif | ||
|
|
||
| #if swift(>=5.6) |
|
API breakage change is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.