Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Sendable in RecvByteBufferAllocator.swift #2148

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Adopt Sendable in RecvByteBufferAllocator.swift #2148

merged 2 commits into from
Jun 1, 2022

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Jun 1, 2022

Incremental Sendable adoption.

@dnadoba dnadoba added the 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Jun 1, 2022
@dnadoba
Copy link
Member Author

dnadoba commented Jun 1, 2022

API breakage failure is a false positive because we use @preconcurrency:

13:01:33 3 breaking changes detected in NIOCore:
13:01:33   💔 API breakage: protocol RecvByteBufferAllocator has generic signature change from  to <Self : NIOCore.NIOPreconcurrencySendable>
13:01:33   💔 API breakage: protocol RecvByteBufferAllocator has added inherited protocol NIOPreconcurrencySendable
13:01:33   💔 API breakage: protocol RecvByteBufferAllocator has added inherited protocol Sendable

@Lukasa Lukasa enabled auto-merge (squash) June 1, 2022 15:07
@Lukasa Lukasa disabled auto-merge June 1, 2022 15:07
@Lukasa Lukasa merged commit 97a568a into apple:main Jun 1, 2022
@dnadoba dnadoba deleted the dn-sendable-recv-byte-buffer-allocator branch June 1, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnadoba @Lukasa @glbrntt