Implement the _failEarlyRangeCheck methods as no-ops #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
Lukasa
reviewed
Jun 6, 2022
…tepan-ulyanin/swift-nio into implement-_failEarlyRangeCheck
Lukasa
approved these changes
Jun 13, 2022
6 tasks
dnadoba
added
the
patch-version-bump-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all versions of the
_failEarlyRangeCheck(_:bounds:)Collection methods as no-ops.Motivation:
#1827 specifies the missing Collection customization points that we would like to customize.
It seems that the
_failEarlyRangeCheck(_:bounds:)should be implemented as no-ops.Modifications:
Adds three methods to the
CircularBufferconforming toCollectionResult:
The default implementations of the
_failEarlyRangeCheckmethods are going to be customized to be no-ops in theCircularBufferstruct.