Throw fatalError when scheduling on shutdown EL if SWIFTNIO_STRICT is set #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set Signed-off-by: Si Beaumont <beaumont@apple.com>
Lukasa
added
patch-version-bump-only
Lukasa
requested changes
Jun 14, 2022
Ah, cool. I had a test for this locally in the unit tests to check crashes which I obviously couldn't add. Good to know there's a place for such a test, I'll see if I can put one in. |
Signed-off-by: Si Beaumont <beaumont@apple.com>
Signed-off-by: Si Beaumont <beaumont@apple.com>
|
Addressed comments and added |
|
Late to the party, thanks for solving this! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When scheduling a task on an EventLoop that is shutdown an error message is printed to stdout which also warns that this will trigger a fatal error in future versions on NIO. #2153 suggests that we should support opting in to fatal errors now by means of an environment variable. It also suggests that any non-fatal error message should be printed to stderr, not stdout.
Modifications:
fatalErrorwhen scheduling tasks if event loop is shutdown when theSWIFTNIO_STRICTenvironment variable is set to something that looks like boolean true.SWIFTNIO_STRICTis not true, continue to print error message, but to stderr.Result:
Fixes #2153.