Adopt Sendable for types in NIOHTTP1
#2213
Conversation
Sources/NIOHTTP1/HTTPTypes.swift
Outdated
| @@ -36,7 +36,7 @@ internal enum KeepAliveState { | |||
|
|
|||
| /// A representation of the request line and header fields of a HTTP request. | |||
| public struct HTTPRequestHead: Equatable { | |||
| private final class _Storage { | |||
| fileprivate final class _Storage { | |||
There was a problem hiding this comment.
I change the access level from private to fileprivate to be able to mark _Storage as non-sendable which is only possible in an extension. No strong optioned on that though, so happy to make it private again.
There was a problem hiding this comment.
I think we don't need to mark internal types as non-sendable, so I'm happy for us to throw this away.
dnadoba
force-pushed
the
dn-sendable-http1-types
branch
from
5c65c77
to
f18dae7
Compare
dnadoba
changed the title
Sendable in NIOHTTP1Sendable for types in NIOHTTP1
dnadoba
added
the
🔼 needs-minor-version-bump
Sources/NIOHTTP1/HTTPTypes.swift
Outdated
| @@ -36,7 +36,7 @@ internal enum KeepAliveState { | |||
|
|
|||
| /// A representation of the request line and header fields of a HTTP request. | |||
| public struct HTTPRequestHead: Equatable { | |||
| private final class _Storage { | |||
| fileprivate final class _Storage { | |||
There was a problem hiding this comment.
I think we don't need to mark internal types as non-sendable, so I'm happy for us to throw this away.
| @@ -301,6 +301,10 @@ public final class NIOHTTPServerRequestAggregator: ChannelInboundHandler, Remova | |||
| } | |||
| } | |||
|
|
|||
| #if swift(>=5.5) && canImport(_Concurrency) | |||
| extension NIOHTTPServerRequestAggregator: @unchecked Sendable {} | |||
There was a problem hiding this comment.
There's no way this type is Sendable.
There was a problem hiding this comment.
Ups 🫣... fixed in 9d78041
|
|
||
|
|
||
| #if swift(>=5.5) && canImport(_Concurrency) | ||
| extension NIOHTTPClientResponseAggregator: @unchecked Sendable {} |
There was a problem hiding this comment.
There's no way this type is Sendable.
There was a problem hiding this comment.
Ups 🫣... fixed in 9d78041
…ggregator` non-Sendable
dnadoba
force-pushed
the
dn-sendable-http1-types
branch
2 times, most recently
from
b9f1884
to
9d78041
Compare
Incremental
Sendableadoption