Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpful error message when compiling without test discovery on >= 5.5 #2264

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

weissi
Copy link
Member

@weissi weissi commented Sep 7, 2022

Motivation:

When compiling on Swift >= 5.5, we require --enable-test-discovery to be passed to swift build --build-tests/swift test. But the error message was terrible.

Modification:

Give a helpful error message when compiling without --enable-test-discovery.

Result:

Less puzzled users.

@weissi weissi requested a review from Lukasa September 7, 2022 14:25
@Lukasa Lukasa added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Sep 7, 2022
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lukasa Lukasa merged commit f169918 into apple:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants