Fix leaked promise in NIOTypedApplicationProtocolNegotiationHandler
#2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
patch-version-bump-only
Lukasa
requested changes
Aug 2, 2023
# Motivation We sometimes leaked a promise in the `NIOTypedApplicationProtocolNegotiationHandler` when the handler was created and immediately deinited. # Modification This PR makes sure we always complete the negotiation promise of the handler. # Result No more leaked promises.
FranzBusch
force-pushed
the
fb-protocol-negotation-promise-leak
branch
from
b979d59
to
2c74d79
Compare
Lukasa
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We sometimes leaked a promise in the
NIOTypedApplicationProtocolNegotiationHandlerwhen the handler was created and immediately deinited.Modification
This PR makes sure we always complete the negotiation promise of the handler.
Result
No more leaked promises.