Avoid using deinit to fulfil the protocol negotiation promise #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
added
the
patch-version-bump-only
Lukasa
requested changes
Aug 7, 2023
| alpnCompleteHandler(result) | ||
| } | ||
| } | ||
|
|
||
| deinit { | ||
| switch self.stateMachine.deinitHandler() { |
There was a problem hiding this comment.
Should we drop the deinitHandler method?
There was a problem hiding this comment.
Yes and the method is dropped from the state machine in this PR.
# Motivation Fixes apple#2494 # Modification This PR avoids using `deinit` to fulfil the protocol negotiation promise and opts to trap instead when it is being accessed before the handler is added. This allows us to use `handlerAdded` and `handlerRemoved`. # Result No more `deinit` usage that can be observed.
FranzBusch
force-pushed
the
fb-protocol-negotiation-trap
branch
from
065667e
to
3e973b2
Compare
Lukasa
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2494
Modification
This PR avoids using
deinitto fulfil the protocol negotiation promise and opts to trap instead when it is being accessed before the handler is added. This allows us to usehandlerAddedandhandlerRemoved.Result
No more
deinitusage that can be observed.