Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CNIOSHA1.h to support C++ interoperability #2523

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

yaglo
Copy link
Contributor

@yaglo yaglo commented Sep 26, 2023

Fixes C++ interoperability by removing static from the array definition when compiling with C++ compiler.

Motivation:

To be able to compile packages with C++ interoperability enabled.

Modifications:

  • Removes static when __cplusplus is defined.
  • Adds extern "C" just in case.

Result:

NIO fully compiles with C++ interoperability enabled.

@Lukasa Lukasa added the semver/patch No public API change. label Sep 27, 2023
@Lukasa
Copy link
Contributor

Lukasa commented Sep 27, 2023

@swift-server-bot test this please

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! ✨

@Lukasa
Copy link
Contributor

Lukasa commented Sep 27, 2023

Merging over the nightly failure, which was not caused by this change.

@Lukasa Lukasa merged commit e4aaf2c into apple:main Sep 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants