Add customization point for scheduling ExecutorJobs on EventLoops
#2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
3 times, most recently
from
c36d0ef
to
d43a1db
Compare
glbrntt
reviewed
Oct 9, 2023
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
2 times, most recently
from
c14ee8a
to
b36ad5a
Compare
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
reviewed
Oct 9, 2023
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
from
b36ad5a
to
8e9d701
Compare
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
2 times, most recently
from
b465a7a
to
2ed0c6f
Compare
glbrntt
reviewed
Oct 9, 2023
# Motivation Currently, the NIO's EventLoop conformance to the `SerialExecutor` protocol always uses `execute` to schedule the actual job. However, the closure for `execute` has to close over the job and the `EventLoop` itself; hence, it always allocates. Since jobs are a very fine grained object in Concurrency that are created a lot this lead to millions of allocations in even small benchmarks. # Modification This PR provides a customization point for `EventLoop`s to execute `ExecutorJob`s directly. For `SelectableEventLoop` we store a type erased `UnownedJob` in our `ScheduledTask` and just run it right away. # Result No more allocations when NIO's EL is used as a `SerialExecutor`.
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
from
2ed0c6f
to
a945ffd
Compare
glbrntt
approved these changes
Oct 9, 2023
FranzBusch
force-pushed
the
fb-serial-executor-performance
branch
from
d18277f
to
a945ffd
Compare
Lukasa
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the NIO's EventLoop conformance to the
SerialExecutorprotocol always usesexecuteto schedule the actual job. However, the closure forexecutehas to close over the job and theEventLoopitself; hence, it always allocates. Since jobs are a very fine grained object in Concurrency that are created a lot this lead to millions of allocations in even small benchmarks.Modification
This PR provides a customization point for
EventLoops to executeExecutorJobs directly. ForSelectableEventLoopwe store a type erasedUnownedJobin ourScheduledTaskand just run it right away.Result
No more allocations when NIO's EL is used as a
SerialExecutor.