Add async version of NIOThreadPool.runIfActive #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
requested changes
Oct 23, 2023
Sources/NIOPosix/NIOThreadPool.swift
Outdated
| @@ -292,6 +292,48 @@ extension NIOThreadPool { | |||
| } | |||
| } | |||
|
|
|||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | |||
| extension NIOThreadPool { | |||
| #if swift(>=5.7) | |||
There was a problem hiding this comment.
We no longer support older versions of Swift than 5.7, so we can drop this conditional compilation step.
There was a problem hiding this comment.
ok, I've removed the older version
adam-fowler
force-pushed
the
async-run-if-active
branch
from
3bdc6c4
to
3f947e4
Compare
Lukasa
reviewed
Oct 24, 2023
Sources/NIOPosix/NIOThreadPool.swift
Outdated
| try await self._runIfActive(body) | ||
| } | ||
|
|
||
| private func _runIfActive<T>(_ body: @escaping () throws -> T) async throws -> T { |
There was a problem hiding this comment.
I don't think we need this inner function now, and so we can avoid dropping the @Sendable annotation here.
Sources/NIOPosix/NIOThreadPool.swift
Outdated
| /// - parameters: | ||
| /// - body: The closure which performs some blocking work to be done on the thread pool. | ||
| /// - returns: result of the passed closure. | ||
| @preconcurrency |
There was a problem hiding this comment.
We can drop preconcurrency, this method doesn't predate concurrency.
Sources/NIOPosix/NIOThreadPool.swift
Outdated
| /// - body: The closure which performs some blocking work to be done on the thread pool. | ||
| /// - returns: result of the passed closure. | ||
| @preconcurrency | ||
| public func runIfActive<T>(_ body: @escaping @Sendable () throws -> T) async throws -> T { |
Remove no longer supported code Add tests for errors being thrown, and the thread pool not being active
adam-fowler
force-pushed
the
async-run-if-active
branch
from
89171e3
to
d0bf0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async version of NIOThreadPool.runIfActive
Motivation:
Currently when using NIOThreadPool in a Swift concurrency context you still need an EventLoop and the call will make two hops, one to the EventLoop and then one back to your Task.
Modifications:
Added
NIOThreadPool.runIfActive(_) async throwsResult:
You don't need an EventLoop to use
NIOThreadPoolThis is the first stage of completing #2565