Mark retroactive conformances appropriately. #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
patch-version-bump-only
dnadoba
approved these changes
Oct 23, 2023
Motivation: In nightly Swift, we now need to mark retroactive conformances when they are intentional. These conformances are safe for us, so we can safely suppress the warnings. Modifications: - Mark NIOFoundationCompat retroactive conformances. Result: Nightly builds work again
Lukasa
force-pushed
the
cb-retroactive-conformances
branch
from
0ecac73
to
008fc29
Compare
dnadoba
approved these changes
Oct 23, 2023
adam-fowler
pushed a commit
to adam-fowler/swift-nio
that referenced
this pull request
Oct 24, 2023
Motivation: In nightly Swift, we now need to mark retroactive conformances when they are intentional. These conformances are safe for us, so we can safely suppress the warnings. Modifications: - Mark NIOFoundationCompat retroactive conformances. Result: Nightly builds work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In nightly Swift, we now need to mark retroactive conformances when they are intentional. These conformances are safe for us, so we can safely suppress the warnings.
Modifications:
Result:
Nightly builds work again