use feature-specific guard for @retroactive #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Motivation: We should use the more granular guard for uses of @retroactive rather than coarse swift versions to guard against corner-cases Modifications: Switch `#if compiler(>=5.11)` for `#if hasFeature(RetroactiveAttribute)` Result: No change in most cases, more protected against corner-cases.
rnro
force-pushed
the
use_hasFeature_RetroactiveAttribute
branch
from
78c2fba
to
ffc2c1d
Compare
I spotted that, thanks! I pushed a revised commit which should work |
dnadoba
approved these changes
Nov 1, 2023
|
For future reference, unfortunately the short-circuiting version doesn't work (on 5.7.3 at least) #if swift(>=5.8) && hasFeature(RetroactiveAttribute) |
rnro
added
the
patch-version-bump-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should use the more granular guard for uses of
@retroactiverather than coarse swift versions to guard against corner-casesModifications:
Switch
#if compiler(>=5.11)for#if hasFeature(RetroactiveAttribute)Result:
No change in most cases, more protected against corner-cases.