Add NIOBSDSocket.Option for SO_BROADCAST #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to setup a broadcast socket using a NIO owned constant instead of directly using a C constant. ```diff - .channelOption(ChannelOptions.socket(SOL_SOCKET, SO_BROADCAST), value: 1) + .channelOption(ChannelOptions.socketOption(.so_broadcast), value: 1) ``` Fixes apple#2674
rauhul
force-pushed
the
add-so-broadcast
branch
from
d7f2619
to
487f2e6
Compare
|
@swift-server-bot add to allowlist |
Lukasa
approved these changes
Mar 11, 2024
glbrntt
added
the
🔼 needs-minor-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to setup a broadcast socket using a NIO owned constant instead of directly using a C constant.
Fixes #2674