Add cancellation to NIOThreadPool's async runIfActive #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To dedupe the thread pool from NIOFileSystem and NIOPosix, the one from NIOPosix needs to gain support for cancellation for its async `runIfActive` function. Modification: - Generate a work ID when submitting async work to the pool, add that ID to a set in the cancellation handler - Check the existence of the ID in the cancel set when dequeuing the work Result: Queued NIOThreadPool tasks can be cancelled before they are run.
glbrntt
added
the
patch-version-bump-only
Lukasa
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To dedupe the thread pool from NIOFileSystem and NIOPosix, the one from NIOPosix needs to gain support for cancellation for its async
runIfActivefunction.Modification:
Result:
Queued NIOThreadPool tasks can be cancelled before they are run.