Handle 'atomically' created files more gracefully when detached #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When a file is created 'atomically' and the descriptor is detached from its handle then the user is provided with the descriptor for a temporary file, and the desired file is never created. Modifications: Where supported, atomically created files use a temporary unnamed file which is then linked on close. Elsewhere a temporary named file is created which is renamed on closed. Temporary unnamed files are linked in detach but not closed. Temporary named files are linked to the desired path before being unlinked. - Break out the logic for materializing a file created using a temporary unnamed file - Add syscalls and error mappings for link(2) and unlink(2) Result: Atomically created files behave as expected when detached
glbrntt
added
the
patch-version-bump-only
Lukasa
reviewed
Mar 14, 2024
| from source: FilePath, | ||
| to destination: FilePath | ||
| ) -> Result<Void, Errno> { | ||
| return nothingOrErrno(retryOnInterrupt: false) { |
There was a problem hiding this comment.
How sure are we that not retrying here is appropriate?
glbrntt
commented
Mar 14, 2024
Lukasa
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a file is created 'atomically' and the descriptor is detached from its handle then the user is provided with the descriptor for a temporary file, and the desired file is never created.
Modifications:
Where supported, atomically created files use a temporary unnamed file which is then linked on close. Elsewhere a temporary named file is created which is renamed on closed.
Temporary unnamed files are linked in detach but not closed. Temporary named files are linked to the desired path before being unlinked.
Result:
Atomically created files behave as expected when detached