Add a way to convert HTTP methods from/to String #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Palleas
force-pushed
the
romain/701
branch
2 times, most recently
from
6ee8874
to
4ef16ff
Compare
|
@swift-nio-bot test this please |
|
@tomerd I reverted back to 2018 for the generated-linux tests and I'll propose a patch soon to bump all the copyrights or something like that. |
|
@swift-nio-bot test this please |
weissi
added
the
🔼 needs-minor-version-bump
weissi
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Thank you! I'm happy with this. Two questions for @Lukasa though:
- do we want the name to be
rawValue? - should be make the constructor fallible? Just in case someone does something clearly illegal like the empty string or something with a space. We don't even need to check the validity today but maybe we should make it fallible just so we can in the future?
Motivation: apple#701 Modifications: * Add `init(rawValue:)` * Add `rawValue` * Add tests in HTTPTypesTest.swift Result: Users no longer have to write their own conversion methods.
|
@swift-nio-bot add to whitelist |
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#701
Modifications:
init(rawValue:)to HTTPMethodrawValueproperty to HTTPMethodResult:
Users no longer have to write their own conversion methods.