Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't hardcode NIO modules #999

Merged
merged 1 commit into from May 10, 2019
Merged

don't hardcode NIO modules #999

merged 1 commit into from May 10, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented May 9, 2019

Motivation:

The new allocation counter suite hardcoded a few things:

  • the NIO and NIOHTTP1 modules
  • no extra dependencies apart from the repo you're in

Modifications:

remove these hardcoded things.

Result:

allocation counter script works for nio-http2. This is all that's necessary to write allocation counter tests for nio-http2:

"$here/../.build/checkouts/swift-nio/IntegrationTests/allocation-counter-tests-framework/run-allocation-counter.sh" \
    -p "$here/.." \
    -m NIO \
    -m NIOHTTP1 \
    -m NIOHTTP2 \
    -d <( echo '.package(url: "https://github.com/apple/swift-nio.git", from: "2.0.0"),' ) \
    "$here"/test_*.swift

@weissi weissi requested a review from Lukasa May 9, 2019 18:17
@Lukasa
Copy link
Contributor

Lukasa commented May 9, 2019

Looks like some tests failed though.

@weissi
don't hardcode NIO modules
33ac412 
Motivation:

The new allocation counter suite hardcoded a few things:
- the NIO and NIOHTTP1 modules
- no extra dependencies apart from the repo you're in

Modifications:

remove these hardcoded things.

Result:

allocation counter script works for nio-http2
@weissi weissi added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label May 10, 2019
@weissi weissi merged commit a2ecd50 into apple:master May 10, 2019
@weissi weissi deleted the jw-dont-hardcode-nio branch May 10, 2019 14:12
@Lukasa Lukasa added this to the 2.2.0 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weissi @Lukasa